Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 10910282: Moved chrome detection to service process. (Closed)

Created:
8 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Moved chrome detection to service process. Renamed related code. BUG=148913 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156906

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -35 lines) Patch
M cloud_print/service/service_switches.h View 1 chunk +3 lines, -2 lines 0 comments Download
M cloud_print/service/service_switches.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 1 2 3 8 chunks +45 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 3 months ago (2012-09-14 18:05:06 UTC) #1
gene
lgtm
8 years, 3 months ago (2012-09-14 18:25:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10910282/1004
8 years, 3 months ago (2012-09-14 18:31:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10910282/1004
8 years, 3 months ago (2012-09-14 22:29:22 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 22:30:06 UTC) #5
Change committed as 156906

Powered by Google App Engine
This is Rietveld 408576698