Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: net/base/upload_file_element_reader.h

Issue 10910268: net: Make UploadDataStream::Read() asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/upload_element_reader.cc ('k') | net/base/upload_file_element_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/upload_file_element_reader.h
diff --git a/net/base/upload_file_element_reader.h b/net/base/upload_file_element_reader.h
index cc8e83053a2979161ed6ad7931e0e4846b814a08..57e8c976f40987193e28cd2cec4d905d73d1482c 100644
--- a/net/base/upload_file_element_reader.h
+++ b/net/base/upload_file_element_reader.h
@@ -31,14 +31,22 @@ class NET_EXPORT_PRIVATE UploadFileElementReader : public UploadElementReader {
virtual int InitSync() OVERRIDE;
virtual uint64 GetContentLength() const OVERRIDE;
virtual uint64 BytesRemaining() const OVERRIDE;
- virtual int ReadSync(char* buf, int buf_length) OVERRIDE;
+ virtual int Read(IOBuffer* buf,
+ int buf_length,
+ const CompletionCallback& callback) OVERRIDE;
+ virtual int ReadSync(IOBuffer* buf, int buf_length) OVERRIDE;
private:
// This method is used to implement Init().
void OnInitCompleted(scoped_ptr<FileStream>* file_stream,
uint64* content_length,
- int* result,
- const CompletionCallback& callback);
+ const CompletionCallback& callback,
+ int result);
+
+ // This method is used to implement Read().
+ void OnReadCompleted(scoped_ptr<FileStream> file_stream,
+ const CompletionCallback& callback,
+ int result);
// Sets an value to override the result for GetContentLength().
// Used for tests.
« no previous file with comments | « net/base/upload_element_reader.cc ('k') | net/base/upload_file_element_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698