Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: net/base/upload_bytes_element_reader_unittest.cc

Issue 10910268: net: Make UploadDataStream::Read() asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/upload_bytes_element_reader.cc ('k') | net/base/upload_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/upload_bytes_element_reader_unittest.cc
diff --git a/net/base/upload_bytes_element_reader_unittest.cc b/net/base/upload_bytes_element_reader_unittest.cc
index 9e68febd493aa58f4157041e2f52241bb1422643..1a3c5d4ebe21c8a4aecaaed9c08737f5925ee68a 100644
--- a/net/base/upload_bytes_element_reader_unittest.cc
+++ b/net/base/upload_bytes_element_reader_unittest.cc
@@ -6,6 +6,7 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
+#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
@@ -31,8 +32,9 @@ class UploadBytesElementReaderTest : public PlatformTest {
TEST_F(UploadBytesElementReaderTest, ReadPartially) {
const size_t kHalfSize = bytes_.size() / 2;
std::vector<char> buf(kHalfSize);
+ scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(buf.size()),
- reader_->ReadSync(&buf[0], buf.size()));
+ reader_->ReadSync(wrapped_buffer, buf.size()));
EXPECT_EQ(bytes_.size() - buf.size(), reader_->BytesRemaining());
bytes_.resize(kHalfSize); // Resize to compare.
EXPECT_EQ(bytes_, buf);
@@ -40,19 +42,21 @@ TEST_F(UploadBytesElementReaderTest, ReadPartially) {
TEST_F(UploadBytesElementReaderTest, ReadAll) {
std::vector<char> buf(bytes_.size());
+ scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(buf.size()),
- reader_->ReadSync(&buf[0], buf.size()));
+ reader_->ReadSync(wrapped_buffer, buf.size()));
EXPECT_EQ(0U, reader_->BytesRemaining());
EXPECT_EQ(bytes_, buf);
// Try to read again.
- EXPECT_EQ(0, reader_->ReadSync(&buf[0], buf.size()));
+ EXPECT_EQ(0, reader_->ReadSync(wrapped_buffer, buf.size()));
}
TEST_F(UploadBytesElementReaderTest, ReadTooMuch) {
const size_t kTooLargeSize = bytes_.size() * 2;
std::vector<char> buf(kTooLargeSize);
+ scoped_refptr<IOBuffer> wrapped_buffer = new WrappedIOBuffer(&buf[0]);
EXPECT_EQ(static_cast<int>(bytes_.size()),
- reader_->ReadSync(&buf[0], buf.size()));
+ reader_->ReadSync(wrapped_buffer, buf.size()));
EXPECT_EQ(0U, reader_->BytesRemaining());
buf.resize(bytes_.size()); // Resize to compare.
EXPECT_EQ(bytes_, buf);
« no previous file with comments | « net/base/upload_bytes_element_reader.cc ('k') | net/base/upload_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698