Fixing missed deallocation of pointer from FileVersionInfo::CreateFileVersionInfoForCurrentModule().

chrome_frame/utils.cc

Index: chrome_frame/utils.cc
diff --git a/chrome_frame/utils.cc b/chrome_frame/utils.cc
index dc8d24cf3d5c548312025a5e41de22e40f1905a4..16d577a3433f399b5de207b92a610752b1c71b41 100644
--- a/chrome_frame/utils.cc
+++ b/chrome_frame/utils.cc
@@ -295,10 +295,10 @@ HRESULT UtilGetXUACompatContentValue(const std::wstring& html_string,
 void DisplayVersionMismatchWarning(HWND parent,
                                    const std::string& server_version) {
   // Obtain the current module version.
-  FileVersionInfo* file_version_info =
-      FileVersionInfo::CreateFileVersionInfoForCurrentModule();
-  DCHECK(file_version_info);
-  std::wstring version_string(file_version_info->file_version());
+  scoped_ptr<FileVersionInfo> module_version_info(
+      FileVersionInfo::CreateFileVersionInfoForCurrentModule());
+  DCHECK(module_version_info.get() != NULL);

[grt (UTC plus 2), 2012/09/14 17:25:58]

please remove this DCHECK as per other review (scoped_ptr<>::operator->
asserts).

[huangs, 2012/09/14 17:48:21]

Done.

+  std::wstring version_string(module_version_info->file_version());
   std::wstring wide_server_version;
   if (server_version.empty()) {
     wide_server_version = SimpleResourceLoader::Get(IDS_VERSIONUNKNOWN);