Fixing missed deallocation of pointer from FileVersionInfo::CreateFileVersionInfoForCurrentModule().

Fixing missed deallocation of pointer from FileVersionInfo::CreateFileVersionInfoForCurrentModule().

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156952

[huangs, 2012-09-13 18:11:55]

Please take a look at this quick fix.  Note that I ignored the presubmit check
on std::wstring to avoid complicating things.

[erikwright (departed), 2012-09-13 18:16:45]

LGTM++.

[commit-bot: I haz the power, 2012-09-14 12:32:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/1

[commit-bot: I haz the power, 2012-09-14 12:32:38]

Presubmit check for 10910257-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome_frame/utils.cc:301

Presubmit checks took 3.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-09-14 12:37:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/1

[commit-bot: I haz the power, 2012-09-14 12:37:38]

Presubmit check for 10910257-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome_frame/utils.cc:301

[erikwright (departed), 2012-09-14 12:48:47]

run a try job and then dcommit.

[erikwright (departed), 2012-09-14 12:49:30]

On 2012/09/14 12:48:47, erikwright wrote:
> run a try job and then dcommit.

Or, if you're not a committer yet, add NOTRY=True to the issue description and
hit the CQ again (after running try jobs).

[commit-bot: I haz the power, 2012-09-14 17:19:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/1

[commit-bot: I haz the power, 2012-09-14 17:19:36]

Presubmit check for 10910257-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome_frame/utils.cc:301

[commit-bot: I haz the power, 2012-09-14 17:24:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/1

[commit-bot: I haz the power, 2012-09-14 17:24:50]

Presubmit check for 10910257-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome_frame/utils.cc:301

Presubmit checks took 3.6s to calculate.

[grt (UTC plus 2), 2012-09-14 17:25:58]

https://chromiumcodereview.appspot.com/10910257/diff/1/chrome_frame/utils.cc
File chrome_frame/utils.cc (right):

https://chromiumcodereview.appspot.com/10910257/diff/1/chrome_frame/utils.cc#...
chrome_frame/utils.cc:300: DCHECK(module_version_info.get() != NULL);
please remove this DCHECK as per other review (scoped_ptr<>::operator->
asserts).

[huangs, 2012-09-14 17:48:21]

Fixed, also for my change, using string16 (else it won't commit).

https://chromiumcodereview.appspot.com/10910257/diff/1/chrome_frame/utils.cc
File chrome_frame/utils.cc (right):

https://chromiumcodereview.appspot.com/10910257/diff/1/chrome_frame/utils.cc#...
chrome_frame/utils.cc:300: DCHECK(module_version_info.get() != NULL);
On 2012/09/14 17:25:58, grt wrote:
> please remove this DCHECK as per other review (scoped_ptr<>::operator->
> asserts).

Done.

[commit-bot: I haz the power, 2012-09-14 17:49:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/11003

[commit-bot: I haz the power, 2012-09-14 18:28:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/5

[commit-bot: I haz the power, 2012-09-14 23:41:36]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-14 23:49:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/10910257/5

[commit-bot: I haz the power, 2012-09-15 01:36:38]

Change committed as 156952