Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Unified Diff: chrome/browser/ui/views/frame/browser_frame_aura.cc

Issue 10910238: ash: Fix blank window when maximizing an app (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/widget/native_widget_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_frame_aura.cc
diff --git a/chrome/browser/ui/views/frame/browser_frame_aura.cc b/chrome/browser/ui/views/frame/browser_frame_aura.cc
index df46354179fc432e5163615eaf0f9dbdcc513e53..f21635ede81edc3df6b432591e4f59260ce8d229 100644
--- a/chrome/browser/ui/views/frame/browser_frame_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_frame_aura.cc
@@ -44,8 +44,13 @@ class BrowserFrameAura::WindowPropertyWatcher : public aura::WindowObserver {
// Allow the frame to be replaced when maximizing an app.
if (browser_frame_->non_client_view() &&
- browser_frame_aura_->browser_view()->browser()->is_app())
- browser_frame_->non_client_view()->UpdateFrame();
+ browser_frame_aura_->browser_view()->browser()->is_app()) {
+ // Defer frame layout when replacing the frame. Layout will occur when the
+ // window's bounds are updated. The window maximize/restore animations
+ // clone the window's layers and rely on the subsequent layout to set
+ // the layer sizes.
+ browser_frame_->non_client_view()->UpdateFrame(false);
+ }
}
virtual void OnWindowBoundsChanged(aura::Window* window,
@@ -85,14 +90,6 @@ BrowserFrameAura::BrowserFrameAura(BrowserFrame* browser_frame,
GetNativeWindow(),
ash::WINDOW_PERSISTS_ACROSS_ALL_WORKSPACES_VALUE_NO);
}
- // HACK: Don't animate app windows. They delete and rebuild their frame on
- // maximize, which breaks the layer animations. We probably shouldn't rebuild
- // the frame view on this transition.
- // TODO(jamescook): Fix app window animation. http://crbug.com/131293
- if (browser_view->browser()->is_app()) {
- Window* window = GetNativeWindow();
- window->SetProperty(aura::client::kAnimationsDisabledKey, true);
- }
#endif
}
« no previous file with comments | « no previous file | ui/views/widget/native_widget_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698