Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10910233: app_list: Make min page switcher button width and spacing smaller. (Closed)

Created:
8 years, 3 months ago by xiyuan
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

app_list: Make min page switcher button width and spacing smaller. - Change min button width from 44px to 28px; - Change min button spacing from 18px to 4px; Also add a 20px padding on left and right so that buttons are aligned with app tiles instead of stretching all the way to the edges. BUG=none. TEST=Verify the UI could hold up to 11 page switcher buttons. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M ui/app_list/page_switcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/page_switcher.cc View 4 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 3 months ago (2012-09-12 17:59:17 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-12 20:58:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10910233/1
8 years, 3 months ago (2012-09-12 22:54:31 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 00:50:38 UTC) #4
Change committed as 156440

Powered by Google App Engine
This is Rietveld 408576698