SearchViewController needs more tests

SearchViewController needs more tests

Adds tests to verify the transition from NTP to when suggestions are
shown, both for "native" suggestions, and "instant" (html) suggestions.

BUG=145827
TEST=SearchViewControllerTest.* browser tests.
R=sky@chromium.org, kuan@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156679

[kuan, 2012-09-12 18:27:43]

lgtm, just nit.

http://codereview.chromium.org/10910232/diff/1/chrome/browser/ui/views/search...
File chrome/browser/ui/views/search_view_controller_browsertest.cc (right):

http://codereview.chromium.org/10910232/diff/1/chrome/browser/ui/views/search...
chrome/browser/ui/views/search_view_controller_browsertest.cc:26: #include
"chrome/common/chrome_notification_types.h"
nit: this shld be b4 chrome_switches.h

[dhollowa, 2012-09-12 18:49:22]

http://codereview.chromium.org/10910232/diff/1/chrome/browser/ui/views/search...
File chrome/browser/ui/views/search_view_controller_browsertest.cc (right):

http://codereview.chromium.org/10910232/diff/1/chrome/browser/ui/views/search...
chrome/browser/ui/views/search_view_controller_browsertest.cc:26: #include
"chrome/common/chrome_notification_types.h"
On 2012/09/12 18:27:43, kuan wrote:
> nit: this shld be b4 chrome_switches.h

Done.

[sky, 2012-09-12 21:28:49]

LGTM

http://codereview.chromium.org/10910232/diff/4002/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/contents_container.h (right):

http://codereview.chromium.org/10910232/diff/4002/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/contents_container.h:33: views::WebView* active()
const { return active_; }
const methods shouldn't return non-const objects, else they be used to
circumvent the constness of this.

[dhollowa, 2012-09-12 22:12:01]

http://codereview.chromium.org/10910232/diff/4002/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/contents_container.h (right):

http://codereview.chromium.org/10910232/diff/4002/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/contents_container.h:33: views::WebView* active()
const { return active_; }
On 2012/09/12 21:28:49, sky wrote:
> const methods shouldn't return non-const objects, else they be used to
> circumvent the constness of this.

Done.

[commit-bot: I haz the power, 2012-09-12 22:13:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10910232/6002

[commit-bot: I haz the power, 2012-09-13 01:12:17]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_chromeos, revision is 156449, job name
was 10910232-6002 (retry) (retry) (retry) (retry).

[dhollowa, 2012-09-13 20:10:10]

Hi Folks, small update to de-flake the tests.  Added a notification to signal
the ntp->suggestion animation is complete.

PTAL.  Should be quick.

[kuan, 2012-09-13 20:16:51]

lgtm, just nit.

http://codereview.chromium.org/10910232/diff/5004/chrome/common/chrome_notifi...
File chrome/common/chrome_notification_types.h (right):

http://codereview.chromium.org/10910232/diff/5004/chrome/common/chrome_notifi...
chrome/common/chrome_notification_types.h:1256: // The source is the
SearchViewController who's animation is finished.
nit: s/who's/whose/

[dhollowa, 2012-09-13 21:01:05]

TBR'ing since this is such a small delta.

[commit-bot: I haz the power, 2012-09-13 21:02:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10910232/10009

[commit-bot: I haz the power, 2012-09-13 23:43:28]

Change committed as 156679