Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 10910229: [net/dns] Collect histogram on HOSTS file size. (Closed)

Created:
8 years, 3 months ago by szym
Modified:
8 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[net/dns] Collect histogram on HOSTS file size. 4% of attempts to parse the HOSTS file fail because reading the file fails. This is likely because files above 65kB are rejected. This CL installs the AsyncDNS.HostsSize histogram to measure the observed size of HOSTS file on each call to ParseHostsFile. BUG=137914 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156327

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M net/dns/dns_hosts.cc View 2 chunks +13 lines, -11 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
szym
http://codereview.chromium.org/10910229/diff/1/net/dns/dns_hosts.cc File net/dns/dns_hosts.cc (left): http://codereview.chromium.org/10910229/diff/1/net/dns/dns_hosts.cc#oldcode52 net/dns/dns_hosts.cc:52: static bool ReadFile(const FilePath& path, int64 max_size, std::string* str) ...
8 years, 3 months ago (2012-09-12 16:42:35 UTC) #1
mmenke
LGTM
8 years, 3 months ago (2012-09-12 16:46:48 UTC) #2
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 16:47:34 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698