Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3188)

Unified Diff: crypto/ec_signature_creator.h

Issue 10910226: crypto: change ECSignatureCreator defaults to match SPDY. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crypto/ec_signature_creator_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/ec_signature_creator.h
diff --git a/crypto/ec_signature_creator.h b/crypto/ec_signature_creator.h
index b557daaf7b0193d8708fd705e77475572251f823..16e64f5753cb85a4506a8e117dc7281d678d004e 100644
--- a/crypto/ec_signature_creator.h
+++ b/crypto/ec_signature_creator.h
@@ -5,6 +5,7 @@
#ifndef CRYPTO_EC_SIGNATURE_CREATOR_H_
#define CRYPTO_EC_SIGNATURE_CREATOR_H_
+#include <string>
#include <vector>
#include "base/basictypes.h"
@@ -31,7 +32,7 @@ class CRYPTO_EXPORT ECSignatureCreator {
// Create an instance. The caller must ensure that the provided PrivateKey
// instance outlives the created ECSignatureCreator.
- // TODO(rch): This is currently hard coded to use SHA1. Ideally, we should
+ // TODO(rch): This is currently hard coded to use SHA256. Ideally, we should
// pass in the hash algorithm identifier.
static ECSignatureCreator* Create(ECPrivateKey* key);
@@ -50,6 +51,14 @@ class CRYPTO_EXPORT ECSignatureCreator {
virtual bool Sign(const uint8* data,
int data_len,
std::vector<uint8>* signature) = 0;
+
+ // DecodeSignature converts from a DER encoded ECDSA-Sig-Value (as produced
+ // by Sign) to a `raw' ECDSA signature which consists of a pair of
+ // big-endian, zero-padded, 256-bit integers, r and s. On success it returns
+ // true and puts the raw signature into |out_raw_sig|.
+ // (Only P-256 signatures are supported.)
+ virtual bool DecodeSignature(const std::vector<uint8>& signature,
+ std::vector<uint8>* out_raw_sig) = 0;
};
} // namespace crypto
« no previous file with comments | « no previous file | crypto/ec_signature_creator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698