Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 10910225: Switch gcl/git upload to use https://codereview.chromium.org instead of https://chromiumcodereview.… (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Switch gcl/git upload to use https://codereview.chromium.org instead of https://chromiumcodereview.appspot.com. It's been a week since the SSL certificate got added, and the old DNS records had a TTL of 7 days. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156316

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M gclient_utils.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/gclient_utils_test.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jam
8 years, 3 months ago (2012-09-12 15:33:49 UTC) #1
M-A Ruel
That's not sufficient, the unit test also needs to be updated. I had did the ...
8 years, 3 months ago (2012-09-12 16:48:52 UTC) #2
jam
On 2012/09/12 16:48:52, Marc-Antoine Ruel wrote: > That's not sufficient, the unit test also needs ...
8 years, 3 months ago (2012-09-12 16:54:58 UTC) #3
M-A Ruel
lgtm
8 years, 3 months ago (2012-09-12 16:56:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/10910225/5001
8 years, 3 months ago (2012-09-12 16:56:27 UTC) #5
commit-bot: I haz the power
Change committed as 156316
8 years, 3 months ago (2012-09-12 16:59:24 UTC) #6
jam
8 years, 3 months ago (2012-09-12 17:09:16 UTC) #7
On 2012/09/12 16:48:52, Marc-Antoine Ruel wrote:
> That's not sufficient, the unit test also needs to be updated.

btw, I had to force upload this because the presubmit checks was spewing a huge
log. see http://pastebin.com/ARVD4fbD. if that worked, would it have told me
about the test failure?

I'm using Windows command prompt, if that makes a difference.

Powered by Google App Engine
This is Rietveld 408576698