runtime/vm/intermediate_language_x64.cc - Issue 10910224: Using type feedback, eliminate store barriers for indexed stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 10910224: Using type feedback, eliminate store barriers for indexed stores. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

===================================================================

--- runtime/vm/intermediate_language_x64.cc (revision 12265)

+++ runtime/vm/intermediate_language_x64.cc (working copy)

@@ -951,7 +951,7 @@

Smi::Cast(index.constant()).Value() * kWordSize + sizeof(RawArray)))

: FieldAddress(array, index.reg(), TIMES_4, sizeof(RawArray));

- if (this->value()->NeedsStoreBuffer()) {

+ if (this->value()->NeedsStoreBuffer() && emit_store_barrier()) {

__ StoreIntoObject(array, field_address, value);

} else {

« runtime/vm/code_generator.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/stub_code.h » ('j') | runtime/vm/stub_code_ia32.cc » ('J')