Using type feedback, eliminate store barriers for indexed stores.

runtime/vm/code_generator.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler_macros.h"
 #include "vm/ast.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 962 matching lines @@
   const Instance& other = Instance::CheckedHandle(arguments.At(1));
   GrowableArray<const Instance*> args(2);
   args.Add(&receiver);
   args.Add(&other);
   const Function& result =
       Function::Handle(InlineCacheMissHandler(isolate, args));
   arguments.SetReturn(result);
 }
 
 
+DEFINE_RUNTIME_ENTRY(InlineCacheMissHandlerThreeArgs, 3) {
+  ASSERT(arguments.Count() ==
+      kInlineCacheMissHandlerThreeArgsRuntimeEntry.argument_count());
+  const Instance& receiver = Instance::CheckedHandle(arguments.At(0));
+  const Instance& other = Instance::CheckedHandle(arguments.At(1));

[Vyacheslav Egorov (Google), 2012/09/12 15:38:09]

why no first and second or arg1, arg2 ?

[srdjan, 2012/09/12 15:45:25]

Done.

+  const Instance& other_other = Instance::CheckedHandle(arguments.At(2));
+  GrowableArray<const Instance*> args(3);
+  args.Add(&receiver);
+  args.Add(&other);
+  args.Add(&other_other);
+  const Function& result =
+      Function::Handle(InlineCacheMissHandler(isolate, args));
+  arguments.SetReturn(result);
+}
+
+
 static RawFunction* LookupDynamicFunction(Isolate* isolate,
                                           const Class& in_cls,
                                           const String& name) {
   Class& cls = Class::Handle();
   // For lookups treat null as an instance of class Object.
   if (in_cls.IsNullClass()) {
     cls = isolate->object_store()->object_class();
   } else {
     cls = in_cls.raw();
   }
@@ skipping 710 matching lines @@
                 current->slot(),
                 current->value());
     }
 
     delete current;
   }
 }
 
 
 }  // namespace dart