Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

base/base_paths_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/base_paths_win.h"
 
 #include <windows.h>
 #include <shlobj.h>
 
+#include "base/base_paths.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/windows_version.h"
 
 // http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
 extern "C" IMAGE_DOS_HEADER __ImageBase;
 
+namespace {
+
+bool GetQuickLaunchPath(bool default_user, FilePath* result) {
+  if (default_user) {
+    wchar_t system_buffer[MAX_PATH];
+    system_buffer[0] = 0;
+    // As per MSDN (http://goo.gl/U8Wcp) passing -1 for |hToken| indicates the

[grt (UTC plus 2), 2012/09/19 16:44:46]

re goo.gl: i'm not a fan of shortened urls here since it adds a dependency on
the shortener.  please use the msdn url directly here and elsewhere.

[gab, 2012/09/19 18:22:58]

Done.

+    // Default user.
+    if (FAILED(SHGetFolderPath(NULL, CSIDL_APPDATA,
+                               reinterpret_cast<HANDLE>(-1), SHGFP_TYPE_CURRENT,
+                               system_buffer))) {
+      return false;
+    }
+    *result = FilePath(system_buffer);
+  } else if (!PathService::Get(base::DIR_APP_DATA, result)) {
+    // For the current user, grab the APPDATA directory directly from the
+    // PathService cache.
+    return false;
+  }
+  // According to various sources (http://goo.gl/3MFtg and http://goo.gl/GxLRL):
+  // appending "Microsoft\Internet Explorer\Quick Launch" to %appdata% is the
+  // only reliable way to get the quick launch folder across all versions of
+  // Windows.
+  *result = result->AppendASCII("Microsoft");
+  *result = result->AppendASCII("Internet Explorer");
+  *result = result->AppendASCII("Quick Launch");
+  return true;
+}
+
+}  // namespace
+
 namespace base {
 
 bool PathProviderWin(int key, FilePath* result) {
 
   // We need to go compute the value. It would be nice to support paths with
   // names longer than MAX_PATH, but the system functions don't seem to be
   // designed for it either, with the exception of GetTempPath (but other
   // things will surely break if the temp path is too long, so we don't bother
   // handling it.
   wchar_t system_buffer[MAX_PATH];
@@ skipping 102 matching lines @@
         return false;
 
       base::win::ScopedCoMem<wchar_t> path_buf;
       if (FAILED(SHGetKnownFolderPath(FOLDERID_ApplicationShortcuts, 0, NULL,
                                       &path_buf)))
         return false;
 
       cur = FilePath(string16(path_buf));
       break;
     }
+    case base::DIR_USER_DESKTOP: {

[grt (UTC plus 2), 2012/09/19 16:44:46]

nit: only use braces when necessary

[gab, 2012/09/19 18:22:58]

Done.

+      if (FAILED(SHGetFolderPath(NULL, CSIDL_DESKTOPDIRECTORY, NULL,
+                                 SHGFP_TYPE_CURRENT, system_buffer))) {
+        return false;
+      }
+      cur = FilePath(system_buffer);
+      break;
+    }
+    case base::DIR_COMMON_DESKTOP: {
+      if (FAILED(SHGetFolderPath(NULL, CSIDL_COMMON_DESKTOPDIRECTORY, NULL,
+                                 SHGFP_TYPE_CURRENT, system_buffer))) {
+        return false;
+      }
+      cur = FilePath(system_buffer);
+      break;
+    }
+    case base::DIR_USER_QUICK_LAUNCH: {
+      if (!GetQuickLaunchPath(false, &cur))
+        return false;
+      break;
+    }
+    case base::DIR_DEFAULT_USER_QUICK_LAUNCH: {
+      if (!GetQuickLaunchPath(true, &cur))
+        return false;
+      break;
+    }
     default:
       return false;
   }
 
   *result = cur;
   return true;
 }
 
 }  // namespace base