Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 10910194: Rename enable-media-source flag to disable-media-source (Closed)

Created:
8 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Rename enable-media-source flag to disable-media-source This instance of enable-media-source was missed in http://crrev.com/155438 . BUG=144669 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
acolwell GONE FROM CHROMIUM
8 years, 3 months ago (2012-09-11 17:50:52 UTC) #1
darin (slow to review)
8 years, 3 months ago (2012-09-11 17:57:27 UTC) #2
LGTM

On Tue, Sep 11, 2012 at 10:50 AM, <acolwell@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Rename enable-media-source flag to disable-media-source
> This instance of enable-media-source was missed in http://crrev.com/155438.
>
> BUG=144669
>
>
> Please review this at
http://codereview.chromium.**org/10910194/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/about_flags.cc
>
>
> Index: chrome/browser/about_flags.cc
> diff --git a/chrome/browser/about_flags.**cc b/chrome/browser/about_flags.
> **cc
> index 60cd3d665d7514d54d026f45c96693**60b0a8e746..**
> 18ed5ec64872325b4a78763ae9f4dd**934adc3f1b 100644
> --- a/chrome/browser/about_flags.**cc
> +++ b/chrome/browser/about_flags.**cc
> @@ -534,7 +534,7 @@ const Experiment kExperiments[] = {
>      MULTI_VALUE_TYPE(**kAsyncDnsChoices)
>    },
>    {
> -    "enable-media-source",
> +    "disable-media-source",
>      IDS_FLAGS_DISABLE_MEDIA_**SOURCE_NAME,
>      IDS_FLAGS_DISABLE_MEDIA_**SOURCE_DESCRIPTION,
>      kOsAll,
>
>
>

Powered by Google App Engine
This is Rietveld 408576698