Issue 10910193: Remove wallpaper app from apps list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910193: Remove wallpaper app from apps list (Closed)

Created:
8 years, 3 months ago by bshe

Modified:
8 years, 3 months ago

Reviewers:
flackr, Mihai Parparita -not on Chrome

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove wallpaper app from apps list BUG=147693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156016

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	chrome/browser/resources/chromeos/wallpaper_manager/manifest.json	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bshe

Hi Rob. Could you please take a look at this trivial CL? We want to ...

8 years, 3 months ago (2012-09-11 14:52:21 UTC) #1

Mihai Parparita -not on Chrome

8 years, 3 months ago (2012-09-12 17:23:01 UTC) #3

Now it's no longer an app, but an extension. Is that intentional?

Mihai

On Tue, Sep 11, 2012 at 7:52 AM, <bshe@chromium.org> wrote:

> Reviewers: flackr,
>
> Message:
> Hi Rob.
>
> Could you please take a look at this trivial CL? We want to remove
> wallpaper app
> from apps list.
>
> Thanks!
>
> Description:
> Remove wallpaper app from apps list
>
>
> BUG=147693
>
>
> Please review this at
http://codereview.chromium.**org/10910193/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/resources/**chromeos/wallpaper_manager/**manifest.json
>
>
> Index: chrome/browser/resources/**chromeos/wallpaper_manager/**
> manifest.json
> diff --git
a/chrome/browser/resources/**chromeos/wallpaper_manager/**manifest.json
> b/chrome/browser/resources/**chromeos/wallpaper_manager/**manifest.json
> index 3bad8f45ec44fd61b2438e8491d1d6**1a25c42f05..**
> 4d9376c77403345ae449d3ce99b09f**f803daca15 100644
> --- a/chrome/browser/resources/**chromeos/wallpaper_manager/**
> manifest.json
> +++ b/chrome/browser/resources/**chromeos/wallpaper_manager/**
> manifest.json
> @@ -15,11 +15,6 @@
>      "http://lh5.ggpht.com/",
>      "http://*.googleapis.com/"
>    ],
> -  "app": {
> -    "launch": {
> -      "local_path": "main.html"
> -    }
> -  },
>    "content_security_policy":
>      "default-src:none; object-src 'none'; script-src 'self'"
>  }
>
>
>

Expand Messages | Collapse Messages