Give Chrome OS more GPU memory

Give Chrome OS more GPU memory.  In particular, allow a maximum usage of 1GB, and remove the per-tab limit.

BUG=147356
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155963

[ccameron, 2012-09-11 01:19:01]

Give Chrome OS more GPU memory.  In particular, allow a maximum usage of 1GB,
and remove the per-tab limit.

Please verify it's OK to spend 1GB on GPU resources on all Chrome OS devices.

This patch continues down the trajectory of #define messiness -- if you'd prefer
that I clean up way that all of the constants are handled in this patch, I can
do that (I'd prefer to do all-or-none).

[piman, 2012-09-11 01:21:47]

https://chromiumcodereview.appspot.com/10910180/diff/4/content/common/gpu/gpu...
File content/common/gpu/gpu_memory_manager.h (right):

https://chromiumcodereview.appspot.com/10910180/diff/4/content/common/gpu/gpu...
content/common/gpu/gpu_memory_manager.h:107: return = 1024 * 1024 * 1024;
'=' typo?

I wouldn't even call GetMaximumTabAllocation on Chrome OS - just making it one
fewer knobs to tweak.

[piman, 2012-09-11 01:25:43]

https://chromiumcodereview.appspot.com/10910180/diff/8001/content/common/gpu/...
File content/common/gpu/gpu_memory_manager.h (right):

https://chromiumcodereview.appspot.com/10910180/diff/8001/content/common/gpu/...
content/common/gpu/gpu_memory_manager.h:107: return 1024 * 1024 * 1024;
or maybe to avoid modifying all the code you can just return
bytes_available_gpu_memory_ here with the same effect.

[ccameron, 2012-09-11 01:30:20]

Good idea, changed to just return (and not "return =")
bytes_available_gpu_memory_.

Any idea why the "git cl try" is instantly failing?

[piman, 2012-09-11 01:31:38]

LGTM. Not sure about the try bots...

[ccameron, 2012-09-11 02:39:54]

On 2012/09/11 01:31:38, piman wrote:
> LGTM. Not sure about the try bots...

Thanks!  I'll commit in the morning when I can watch it.

[commit-bot: I haz the power, 2012-09-11 02:40:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/10910180/6002

[piman, 2012-09-11 02:41:54]

On Mon, Sep 10, 2012 at 7:39 PM, <ccameron@chromium.org> wrote:

> On 2012/09/11 01:31:38, piman wrote:
>
>> LGTM. Not sure about the try bots...
>>
>
> Thanks!  I'll commit in the morning when I can watch it.
>

I clicked it. Are you a committer? Maybe that's it?

Antoine


>
https://chromiumcodereview.**appspot.com/10910180/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2012-09-11 06:42:19]

Change committed as 155963