Separate plugin_metadata from plugin_installer, thread-safe plugin_finder

chrome/browser/browser_process_impl.cc

Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index d4f33666beb5f5002c4b27a6536e9685def34729..8d9c36f022d19b011c4f4a335c282814d8daced9 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -42,6 +42,7 @@
 #include "chrome/browser/net/crl_set_fetcher.h"
 #include "chrome/browser/net/sdch_dictionary_fetcher.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
+#include "chrome/browser/plugins/plugin_finder.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #include "chrome/browser/policy/policy_service.h"
 #include "chrome/browser/prefs/browser_prefs.h"
@@ -791,6 +792,9 @@ void BrowserProcessImpl::PreMainMessageLoopRun() {
 
   if (local_state_->IsManagedPreference(prefs::kDefaultBrowserSettingEnabled))
     ApplyDefaultBrowserPolicy();
+
+  // Triggers initialization of the singleton instance on UI thread.

[Bernhard Bauer, 2012/09/24 09:14:25]

Oh, I forgot that we need to make sure PluginFinder is initialized on the right
thread. In that case we don't really gain anything from using custom Singleton
traits, do we? Also, at some point we're probably going to need to initialize
PluginFinder with Local State anyway. I'll leave it to you if want to go back to
explicit initialization or keep the custom Singleton Traits.

[ibraaaa, 2012/09/24 11:01:07]

Now I understood your point in using custom traits here :)

On 2012/09/24 09:14:25, Bernhard Bauer wrote:

+  PluginFinder::GetInstance();
 }
 
 void BrowserProcessImpl::CreateIconManager() {