Issue 10910162: contacts: Apply nits to ContactMap class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910162: contacts: Apply nits to ContactMap class. (Closed)

Created:
8 years, 3 months ago by Daniel Erat

Modified:
8 years, 3 months ago

Reviewers:
tfarina

CC:
chromium-reviews, derat+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

contacts: Apply nits to ContactMap class. This applies some nits from tfarina@ that came in after I committed the change that added this class. BUG=128805 TEST=none TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155778

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/chromeos/contacts/contact_map.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/contacts/contact_map_unittest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10910162/1

8 years, 3 months ago (2012-09-10 15:02:58 UTC) #2

Change committed as 155778

Expand Messages | Collapse Messages