Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: runtime/vm/object_test.cc

Issue 10910119: Implement new optional parameters syntax in the vm (issue 4290). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 12003)
+++ runtime/vm/object_test.cc (working copy)
@@ -40,8 +40,10 @@
const int kNumFixedParameters = 2;
const int kNumOptionalParameters = 3;
- function.set_num_fixed_parameters(kNumFixedParameters);
- function.set_num_optional_parameters(kNumOptionalParameters);
+ const bool kAreOptionalPositional = true;
+ function.SetNumberOfParameters(kNumFixedParameters,
+ kNumOptionalParameters,
+ kAreOptionalPositional);
functions.SetAt(1, function);
function_name = Symbols::New("baz");
@@ -91,13 +93,15 @@
function = cls.LookupDynamicFunction(function_name);
EXPECT(!function.IsNull());
EXPECT_EQ(0, function.num_fixed_parameters());
- EXPECT_EQ(0, function.num_optional_parameters());
+ EXPECT(!function.HasOptionalParameters());
function_name = String::New("bar");
function = cls.LookupDynamicFunction(function_name);
EXPECT(!function.IsNull());
EXPECT_EQ(kNumFixedParameters, function.num_fixed_parameters());
- EXPECT_EQ(kNumOptionalParameters, function.num_optional_parameters());
+ EXPECT_EQ(kNumOptionalParameters,
+ function.num_optional_positional_parameters() +
+ function.num_optional_named_parameters());
const Array& interfaces = Array::Handle(Array::New(2));
Class& interface = Class::Handle();
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698