runtime/vm/dart_api_impl.cc - Issue 10910119: Implement new optional parameters syntax in the vm (issue 4290).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 10910119: Implement new optional parameters syntax in the vm (issue 4290). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

===================================================================

--- runtime/vm/dart_api_impl.cc (revision 12003)

+++ runtime/vm/dart_api_impl.cc (working copy)

@@ -2839,7 +2839,9 @@

// provide them in the argument lists they are handed.

*fixed_param_count = (func.num_fixed_parameters() -

func.NumberOfImplicitParameters());

- *opt_param_count = func.num_optional_parameters();

+ // TODO(regis): Separately report named and positional optional param counts.

+ *opt_param_count = (func.num_optional_positional_parameters() +

+ func.num_optional_named_parameters());

ASSERT(*fixed_param_count >= 0);

ASSERT(*opt_param_count >= 0);

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph.h » ('j') | no next file with comments »