Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10910110: Fixed deoptimization of inlined getters. (Closed)

Created:
8 years, 3 months ago by Sven Panne
Modified:
8 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fixed deoptimization of inlined getters. It is necessary to explicitly handle the internal frame lying between the caller of the getter and the getter itself in the deoptimizer: When the getter is inlined, leaving the internal frame restores the correct context. BUG=http://crbug/134609 TEST=mjsunit/regress/regress-crbug-134609 Committed: https://code.google.com/p/v8/source/detail?r=12470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -173 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/deoptimizer-arm.cc View 3 chunks +34 lines, -24 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +38 lines, -13 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 7 chunks +16 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 3 chunks +34 lines, -24 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +38 lines, -13 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 3 chunks +34 lines, -24 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +38 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/stub-cache.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 3 chunks +34 lines, -24 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +38 lines, -13 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-134609.js View 1 chunk +25 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 3 months ago (2012-09-06 13:32:06 UTC) #1
Michael Starzinger
8 years, 3 months ago (2012-09-07 08:20:53 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698