Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: native_client_sdk/src/build_tools/update_nacl_manifest.py

Issue 10910101: fix pylint warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/update_nacl_manifest.py
diff --git a/native_client_sdk/src/build_tools/update_nacl_manifest.py b/native_client_sdk/src/build_tools/update_nacl_manifest.py
index 7363834251e6a98a77aff33c1feac75bee976afc..9f2a09a526ea9263fff48da6e278a4d58a990728 100755
--- a/native_client_sdk/src/build_tools/update_nacl_manifest.py
+++ b/native_client_sdk/src/build_tools/update_nacl_manifest.py
@@ -7,6 +7,9 @@
in manifest.
"""
+# pylint is convinced the email module is missing attributes
+# pylint: disable=E1101
+
import buildbot_common
import csv
import cStringIO
@@ -92,6 +95,7 @@ def GetPlatformsFromArchives(archive_urls):
class Delegate(object):
"""Delegate all external access; reading/writing to filesystem, gsutil etc."""
+
def GetRepoManifest(self):
"""Read the manifest file from the NaCl SDK repository.
@@ -157,7 +161,6 @@ class Delegate(object):
effect is that text in stdin is copied to |dest|."""
raise NotImplementedError()
-
def Print(self, *args):
"""Print a message."""
raise NotImplementedError()
@@ -165,6 +168,7 @@ class Delegate(object):
class RealDelegate(Delegate):
def __init__(self, dryrun=False, gsutil=None):
+ super(RealDelegate, self).__init__()
self.dryrun = dryrun
if gsutil:
self.gsutil = gsutil
@@ -313,6 +317,7 @@ class VersionFinder(object):
'canary'). |archives| is a list of archive URLs."""
version = None
skipped_versions = []
+ channel = ''
while True:
try:
version, channel = shared_version_generator.next()

Powered by Google App Engine
This is Rietveld 408576698