Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: native_client_sdk/src/build_tools/build_updater.py

Issue 10910101: fix pylint warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/build_tools/build_sdk.py ('k') | native_client_sdk/src/build_tools/build_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_updater.py
diff --git a/native_client_sdk/src/build_tools/build_updater.py b/native_client_sdk/src/build_tools/build_updater.py
index efe610a40b36ab28b0ebedfc2852484a26751f4c..8283790d0990c350cd87832b19b6dddfecd58a80 100755
--- a/native_client_sdk/src/build_tools/build_updater.py
+++ b/native_client_sdk/src/build_tools/build_updater.py
@@ -11,10 +11,8 @@ tool users run to download new bundles, update existing bundles, etc.
import buildbot_common
import build_utils
-import cStringIO
import optparse
import os
-import re
import sys
SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
@@ -111,9 +109,9 @@ def UpdateRevisionNumber(out_dir, revision_number):
SDK_UPDATE_MAIN = os.path.join(out_dir,
'nacl_sdk/sdk_tools/sdk_update_main.py')
- file = open(SDK_UPDATE_MAIN, 'r').read().replace(
+ contents = open(SDK_UPDATE_MAIN, 'r').read().replace(
'{REVISION}', str(revision_number))
- open(SDK_UPDATE_MAIN, 'w').write(file)
+ open(SDK_UPDATE_MAIN, 'w').write(contents)
def BuildUpdater(out_dir, revision_number=None):
@@ -131,7 +129,7 @@ def BuildUpdater(out_dir, revision_number=None):
buildbot_common.RemoveDir(os.path.join(out_dir, 'nacl_sdk'))
updater_files = MakeUpdaterFilesAbsolute(out_dir)
- out_files = [out_file for in_file, out_file in updater_files]
+ out_files = [out_file for _, out_file in updater_files]
CopyFiles(updater_files)
UpdateRevisionNumber(out_dir, revision_number)
« no previous file with comments | « native_client_sdk/src/build_tools/build_sdk.py ('k') | native_client_sdk/src/build_tools/build_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698