fix pylint warnings

native_client_sdk/src/build_tools/sdk_tools/sdk_update_main.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''A simple tool to update the Native Client SDK to the latest version'''
 
 import cStringIO
 import cygtar
 import json
 import manifest_util
 import optparse
 import os
-from sdk_update_common import *
+from sdk_update_common import RenameDir, RemoveDir, Error
 import shutil
 import subprocess
 import sys
 import tempfile
+# when pylint runs the third_party module is the one from depot_tools
+# pylint: disable=E0611
 from third_party import fancy_urllib
 import urllib2
 import urlparse
 
+# pylint: disable=C0301
 
 #------------------------------------------------------------------------------
 # Constants
 
 # This revision number is autogenerated from the Chrome revision.
 REVISION = '{REVISION}'
 
 GLOBAL_HELP = '''Usage: naclsdk [options] command [command_options]
 
 naclsdk is a simple utility that updates the Native Client (NaCl)
@@ skipping 260 matching lines @@
         scheme != 'https' or
         not path.startswith('/nativeclient-mirror/nacl/nacl_sdk')):
       WarningPrint('Only whitelisted sources from '
                    '\'https://commondatastorage.googleapis.com/nativeclient-'
                    'mirror/nacl/nacl_sdk\' are currently allowed.')
       return
     if string in self._data['sources']:
       WarningPrint('source \''+string+'\' already exists in config.')
       return
     try:
-      url_stream = UrlOpen(string)
+      UrlOpen(string)
     except urllib2.URLError:
       WarningPrint('Unable to fetch manifest URL \'%s\'. Exiting...' % string)
       return
 
     self._data['sources'].append(string)
     InfoPrint('source \''+string+'\' added to config.')
 
   def RemoveSource(self, string):
     '''Remove a source file to load packages from.
 
@@ skipping 50 matching lines @@
 
 
 def Info(options, argv, config):
   '''Usage: %prof [global_options] info [options] bundle_names...
 
   Displays information about a SDK bundle.'''
 
   DebugPrint("Running List command with: %s, %s" %(options, argv))
 
   parser = optparse.OptionParser(usage=Info.__doc__)
-  (info_options, args) = parser.parse_args(argv)
+  (_, args) = parser.parse_args(argv)
 
   if not args:
     parser.print_help()
     return
 
   manifest = LoadManifestFromURLs([options.manifest_url] + config.GetSources())
   valid_bundles = [bundle.name for bundle in manifest.GetBundles()]
   valid_args = set(args) & set(valid_bundles)
   invalid_args = set(args) - valid_args
   if invalid_args:
@@ skipping 44 matching lines @@
       revision))
 
 
   DebugPrint("Running List command with: %s, %s" %(options, argv))
 
   parser = optparse.OptionParser(usage=List.__doc__)
   parser.add_option(
       '-r', '--revision', dest='revision',
       default=False, action='store_true',
       help='display revision numbers')
-  (list_options, args) = parser.parse_args(argv)
+  (list_options, _) = parser.parse_args(argv)
 
   manifest = LoadManifestFromURLs([options.manifest_url] + config.GetSources())
   manifest_path = os.path.join(options.user_data_dir, options.manifest_filename)
   local_manifest = LoadFromFile(manifest_path, manifest_util.SDKManifest())
 
   any_bundles_need_update = False
   InfoPrint('Bundles:')
   InfoPrint(' I: installed\n *: update available\n')
   for bundle in manifest.GetBundles():
     local_bundle = local_manifest.GetBundle(bundle.name)
-    installed = local_bundle is not None
     needs_update = local_bundle and local_manifest.BundleNeedsUpdate(bundle)
     if needs_update:
       any_bundles_need_update = True
 
     PrintBundle(local_bundle, bundle, needs_update, list_options.revision)
 
   if not any_bundles_need_update:
     InfoPrint('\nAll installed bundles are up-to-date.')
 
   local_only_bundles = set([b.name for b in local_manifest.GetBundles()])
@@ skipping 286 matching lines @@
 
   return 0  # Success
 
 
 if __name__ == '__main__':
   try:
     sys.exit(main(sys.argv[1:]))
   except Error as error:
     print "Error: %s" % error
     sys.exit(1)