fix pylint warnings

native_client_sdk/src/build_tools/build_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Small utility library of python functions used by the various package
 installers.
 """
 
 import datetime
 import errno
 import fileinput
 import os
 import platform
 import re
 import shutil
 import subprocess
 import sys
 
+# pylint: disable=E0602
 
 # Reuse last change utility code.
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 SRC_DIR = os.path.dirname(os.path.dirname(os.path.dirname(SCRIPT_DIR)))
 sys.path.append(os.path.join(SRC_DIR, 'build/util'))
 import lastchange
 
 
 # Location of chrome's version file.
 VERSION_PATH = os.path.join(SRC_DIR, 'chrome', 'VERSION')
@@ skipping 47 matching lines @@
 # file, it is removed before an attempt to make the directories.  If |abs_path|
 # already points to a directory, this method does nothing.
 def ForceMakeDirs(abs_path, mode=0755):
   if os.path.isdir(abs_path):
     return
   try:
     # Remove an existing regular file; ignore errors (e.g. file doesn't exist).
     # If there are permission problems, they will be caught by the exception
     # handler around the os.makedirs call.
     os.remove(abs_path)
-  except:
+  except OSError:
     pass
   try:
     os.makedirs(abs_path, mode)
-  except OSError, (os_errno, os_strerr):
+  except OSError, e:
     # If the error is anything but EEXIST (file already exists), then print an
     # informative message and re-raise.  It is not and error if the directory
     # already exists.
+    (os_errno, os_strerr) = e
     if os_errno != errno.EEXIST:
       print 'ForceMakeDirs(%s, 0%o) FAILED: %s' % (abs_path, mode, os_strerr)
       raise
-    pass
 
 
 # patch version 2.6 doesn't work.  Most of our Linux distros use patch 2.6.
 # Returns |True| if the version of patch is usable (that is, not version 2.6).
 # |shell_env| is the enviromnent used to run the subprocesses like patch and
 # sed.  If |shell_env| is None, then os.environ is used.
 def CheckPatchVersion(shell_env=None):
   if shell_env is None:
     shell_env = os.environ
   patch = subprocess.Popen("patch --version",
@@ skipping 174 matching lines @@
 
 
 def UpdateReadMe(filename):
   '''Updates the README file in the SDK with the current date and version'''
 
   for line in fileinput.input(filename, inplace=1):
     sys.stdout.write(line.replace('${VERSION}', PLATFORM_VERSION)
                      .replace('${REVISION}', str(SVNRevision()))
                      .replace('${DATE}', str(datetime.date.today())))
 
-def CleanDirectory(dir):
+def CleanDirectory(dirname):
   '''Cleans all the contents of a given directory.
   This works even when there are Windows Junctions in the directory
 
   Args:
-    dir: The directory to clean
+    dirname: The directory to clean
   '''
   if sys.platform != 'win32':
-    shutil.rmtree(dir, ignore_errors=True)
+    shutil.rmtree(dirname, ignore_errors=True)
   else:
     # Intentionally ignore return value since a directory might be in use.
-    subprocess.call(['rmdir', '/Q', '/S', dir],
+    subprocess.call(['rmdir', '/Q', '/S', dirname],
                     env=os.environ.copy(),
                     shell=True)