Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10910093: Merged r12434, r12435, r12440, r12441, r12443, r12444, r12445, r12446 into trunk branch. (Closed)

Created:
8 years, 3 months ago by Jakob Kummerow
Modified:
8 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Merged r12434, r12435, r12440, r12441, r12443, r12444, r12445, r12446 into trunk branch. Support register as right operand in min/max support. Fixed test expectation. Add build system infrastructure for ENABLE_EXTRA_CHECKS flag (not used yet) Fix missing colon in common.gypi Push stacktrace and die if the receiver is of unknown type. Disable accessor inlining (due to broken deopts) Add empty-handle checks to API functions (#ifdef ENABLE_EXTRA_CHECKS) Check the return value of API calls on ia32 and x64. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -79 lines) Patch
M Makefile View 1 chunk +7 lines, -0 lines 0 comments Download
M build/common.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M src/api.h View 4 chunks +36 lines, -59 lines 0 comments Download
M src/api.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M src/checks.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +17 lines, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-145961.js View 1 chunk +9 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
8 years, 3 months ago (2012-09-05 16:42:04 UTC) #1
Yang
On 2012/09/05 16:42:04, Jakob wrote: rubberstamped LGTM.
8 years, 3 months ago (2012-09-05 16:44:18 UTC) #2
mykesx
8 years, 3 months ago (2012-09-06 23:08:45 UTC) #3
On 2012/09/05 16:42:04, Jakob wrote:

Please see:
https://groups.google.com/forum/?fromgroups=#!topic/v8-users/gS1SMb1Tjks

Check return value of API calls does not allow for External::New() type return
values.  Please fix this.

Powered by Google App Engine
This is Rietveld 408576698