Issue 10910091: Extend grokdump.py with [u]nassemble command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910091: Extend grokdump.py with [u]nassemble command (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Extend grokdump.py with [u]nassemble command R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12447

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	tools/grokdump.py	View		1 chunk	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one nit). https://chromiumcodereview.appspot.com/10910091/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10910091/diff/1/tools/grokdump.py#newcode1481 tools/grokdump.py:1481: def do_u(self, args): Can we ...

8 years, 3 months ago (2012-09-05 16:07:39 UTC) #2

Vyacheslav Egorov (Google)

8 years, 3 months ago (2012-09-05 16:23:34 UTC) #3

Sorted do_* methods. Landed.

Thanks for the review!

Expand Messages | Collapse Messages