Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 10910091: Extend grokdump.py with [u]nassemble command (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Extend grokdump.py with [u]nassemble command R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12447

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M tools/grokdump.py View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-09-05 15:59:56 UTC) #1
Michael Starzinger
LGTM (with one nit). https://chromiumcodereview.appspot.com/10910091/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10910091/diff/1/tools/grokdump.py#newcode1481 tools/grokdump.py:1481: def do_u(self, args): Can we ...
8 years, 3 months ago (2012-09-05 16:07:39 UTC) #2
Vyacheslav Egorov (Google)
8 years, 3 months ago (2012-09-05 16:23:34 UTC) #3
Sorted do_* methods. Landed.

Thanks for the review!

Powered by Google App Engine
This is Rietveld 408576698