The 'test' command is not always usable on android

The 'test' command is not always usable on android

In emulator or some devices, there is no 'test' command. So workaround
this by using 'ls' to do this kind of check.

BUG=
TEST=run_test.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155170

[yongsheng, 2012-09-05 07:48:30]

hi, owners, 
I can't run unit tests in emulators without this patch. That's because emulators
don't support 'test' or 'if -f' commands.  So could you please help review it?

[bulach, 2012-09-05 13:44:23]

lgtm, thanks for the fix!

[yongsheng, 2012-09-06 00:45:44]

On 2012/09/05 13:44:23, bulach wrote:
> lgtm, thanks for the fix!
thanks.
Sami, do you have any comments?

[Sami, 2012-09-06 09:34:14]

On 2012/09/06 00:45:44, yongsheng wrote:
> Sami, do you have any comments?

I think your fix looks fine, lgtm. Thanks for making this work.

[yongsheng, 2012-09-06 09:36:02]

On 2012/09/06 09:34:14, Sami wrote:
> On 2012/09/06 00:45:44, yongsheng wrote:
> > Sami, do you have any comments?
> 
> I think your fix looks fine, lgtm. Thanks for making this work.
ok, thanks you two.

[commit-bot: I haz the power, 2012-09-06 09:38:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10910087/1

[commit-bot: I haz the power, 2012-09-06 12:04:08]

Change committed as 155170

[nduca, 2012-09-07 00:41:21]

:'(

Y'all, careful with find!

https://chromiumcodereview.appspot.com/10930002/

[Isaac (away), 2012-09-07 01:02:38]

https://chromiumcodereview.appspot.com/10910087/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10910087/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:1014: if not status[0].find('test: not
found'):
This seems overly protective, can we just assume the test command will exist on
the device?

https://chromiumcodereview.appspot.com/10910087/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:1018: if not status[0].find('No such
file or directory'):
change to:

'No such file or directory' not in status[0]

[yongsheng, 2012-09-07 01:07:04]

thanks.

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
build/android/pylib/android_commands.py:1014: if not status[0].find('test: not
found'):
On 2012/09/07 01:02:38, Isaac wrote:
> This seems overly protective, can we just assume the test command will exist
on
> the device?
I run this on emulators for ARM and x86, both of them don't have this kind of
'test' command.

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
build/android/pylib/android_commands.py:1018: if not status[0].find('No such
file or directory'):
On 2012/09/07 01:02:38, Isaac wrote:
> change to:
> 
> 'No such file or directory' not in status[0]
So below patch is also for this issue. Need I change it here? 
http://codereview.chromium.org/10930002

[yongsheng, 2012-09-07 01:28:07]

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
build/android/pylib/android_commands.py:1014: if not status[0].find('test: not
found'):
On 2012/09/07 01:07:05, yongsheng wrote:
> On 2012/09/07 01:02:38, Isaac wrote:
> > This seems overly protective, can we just assume the test command will exist
> on
> > the device?
> I run this on emulators for ARM and x86, both of them don't have this kind of
> 'test' command.
See the error in emulators:
invalid literal for int() with base 10: 'test: not found\r\n127\r\n'

[yongsheng, 2012-09-07 01:30:13]

upload a new one. please have a check.

[yongsheng, 2012-09-10 01:29:54]

On 2012/09/07 01:30:13, yongsheng wrote:
> upload a new one. please have a check.
@Issac and @nduca, if no other comments, I'll re-land it again. Thanks.

[Isaac (away), 2012-09-10 01:48:45]

When you upload the new CL add me to the review and I'll check it over.  
Thanks!

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
build/android/pylib/android_commands.py:1018: if not status[0].find('No such
file or directory'):
That patch wasn't landed (it's going to be abandoned).  Instead, we reverted
this one.

You'll need to make a new CL if you want to reland.

[yongsheng, 2012-09-10 01:50:19]

On 2012/09/10 01:48:45, Isaac wrote:
> When you upload the new CL add me to the review and I'll check it over.  
> Thanks!
> 
>
http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
> File build/android/pylib/android_commands.py (right):
> 
>
http://codereview.chromium.org/10910087/diff/1/build/android/pylib/android_co...
> build/android/pylib/android_commands.py:1018: if not status[0].find('No such
> file or directory'):
> That patch wasn't landed (it's going to be abandoned).  Instead, we reverted
> this one.
> 
> You'll need to make a new CL if you want to reland.
ok, i'll create a new one. Thanks.