[Chromoting] Adding the desktop integration binary to the host installation on Windows.

[Chromoting] Adding the desktop integration binary to the host installation on Windows.

The desktop integration binary is compiled and added to the host installation only when a multi-process host is built. This CL also renames a few constants to match the multi process host terminology more closely.

BUG=134694
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156395

[alexeypa (please no reviews), 2012-09-04 17:52:18]

PTAL.

[garykac, 2012-09-05 22:40:41]

I like the updated names, but they're not being applied consistently so we now
have remoting_daemon, remoting_service and host_service for the same component.

and remoting_host_me2me builds remoting_me2me_host.exe.

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.wxs
File remoting/host/win/chromoting.wxs (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.w...
remoting/host/win/chromoting.wxs:148: <File Id="remoting_desktop.exe"
Shouldn't these targets be called _daemon as well?

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.w...
remoting/host/win/chromoting.wxs:182: <Component Id="remoting_host" Guid="*">
Why not remoting_host_me2me?

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/elevated_con...
File remoting/host/win/elevated_controller.ver (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/elevated_con...
remoting/host/win/elevated_controller.ver:4:
ORIGINAL_FILENAME=remoting_host_controller.exe
If you're renaming this from host controller, then this should be
remoting_controller.exe for consistency.

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/host_service...
File remoting/host/win/host_service.ver (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/host_service...
remoting/host/win/host_service.ver:3: INTERNAL_NAME=remoting_service.exe
Rename to remoting_daemon.exe

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode656
remoting/remoting.gyp:656: 'host/win/elevated_controller.ver',
controller.ver?

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode657
remoting/remoting.gyp:657: 'host/win/host_service.ver',
daemon.ver?

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode721
remoting/remoting.gyp:721: '<(PRODUCT_DIR)/remoting_host_controller.exe',
remoting_controller?

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode722
remoting/remoting.gyp:722: '<(PRODUCT_DIR)/remoting_me2me_host.exe',
remoting_host_me2me for consistency with you renaming this elsewhere

[Sergey Ulanov, 2012-09-05 23:03:57]

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode722
remoting/remoting.gyp:722: '<(PRODUCT_DIR)/remoting_me2me_host.exe',
On 2012/09/05 22:40:42, garykac wrote:
> remoting_host_me2me for consistency with you renaming this elsewhere

FYI on linux we renamed main host binary to chrome-remote-desktop-host. Maybe
use the same name here for consistency. Or remoting_host.exe should work fine.
It's best to avoid using "me2me" as part of the name.

[alexeypa (please no reviews), 2012-09-05 23:24:02]

The main problem is that I cannot touch the file names until the signing script
is updated. There is also FILES.cfg and, maybe, some GYP targets are referenced
elsewhere in the tree. 

I'm going to rename the files and targets in follow up CLs.

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.wxs
File remoting/host/win/chromoting.wxs (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.w...
remoting/host/win/chromoting.wxs:148: <File Id="remoting_desktop.exe"
On 2012/09/05 22:40:42, garykac wrote:
> Shouldn't these targets be called _daemon as well?

No, this one is installing the desktop integration process binary. So it is
"desktop".

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.w...
remoting/host/win/chromoting.wxs:182: <Component Id="remoting_host" Guid="*">
On 2012/09/05 22:40:42, garykac wrote:
> Why not remoting_host_me2me?

Done.

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/elevated_con...
File remoting/host/win/elevated_controller.ver (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/elevated_con...
remoting/host/win/elevated_controller.ver:4:
ORIGINAL_FILENAME=remoting_host_controller.exe
On 2012/09/05 22:40:42, garykac wrote:
> If you're renaming this from host controller, then this should be
> remoting_controller.exe for consistency.

I cannot touch the file names just yet, because the signing script is not ready.

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/host_service...
File remoting/host/win/host_service.ver (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/host_service...
remoting/host/win/host_service.ver:3: INTERNAL_NAME=remoting_service.exe
On 2012/09/05 22:40:42, garykac wrote:
> Rename to remoting_daemon.exe

Once the signing script is ready.

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode656
remoting/remoting.gyp:656: 'host/win/elevated_controller.ver',
On 2012/09/05 22:40:42, garykac wrote:
> controller.ver?

Done.

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode657
remoting/remoting.gyp:657: 'host/win/host_service.ver',
On 2012/09/05 22:40:42, garykac wrote:
> daemon.ver?

Done.

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode721
remoting/remoting.gyp:721: '<(PRODUCT_DIR)/remoting_host_controller.exe',
On 2012/09/05 22:40:42, garykac wrote:
> remoting_controller?

Cannot touch file names yet.

http://codereview.chromium.org/10910075/diff/1/remoting/remoting.gyp#newcode722
remoting/remoting.gyp:722: '<(PRODUCT_DIR)/remoting_me2me_host.exe',
On 2012/09/05 22:40:42, garykac wrote:
> remoting_host_me2me for consistency with you renaming this elsewhere

Cannot touch file names yet.

[alexeypa (please no reviews), 2012-09-05 23:26:09]

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.wxs
File remoting/host/win/chromoting.wxs (right):

http://codereview.chromium.org/10910075/diff/1/remoting/host/win/chromoting.w...
remoting/host/win/chromoting.wxs:182: <Component Id="remoting_host" Guid="*">
On 2012/09/05 23:24:02, alexeypa wrote:
> On 2012/09/05 22:40:42, garykac wrote:
> > Why not remoting_host_me2me?
> 
> Done.

Actually - not done, since Sergey suggested to avoid me2me.

[garykac, 2012-09-11 21:30:10]

lgtm

[commit-bot: I haz the power, 2012-09-11 22:25:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10910075/1013

[commit-bot: I haz the power, 2012-09-12 00:13:39]

Try job failure for 10910075-1013 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-09-12 17:55:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10910075/8017

[commit-bot: I haz the power, 2012-09-12 18:45:02]

Try job failure for 10910075-8017 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-09-12 18:48:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10910075/8017

[commit-bot: I haz the power, 2012-09-12 22:12:40]

Change committed as 156395