Issue 10910062: Fix android.gypi to provide correct include and library paths when using standalone Android toolcha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910062: Fix android.gypi to provide correct include and library paths when using standalone Android toolcha… (Closed)

Created:
8 years, 3 months ago by ulan

Modified:
8 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix android.gypi to provide correct include and library paths when using standalone Android toolchain. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12425

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -34 lines)			Patch
	M	Makefile.android	View		3 chunks	+9 lines, -9 lines	0 comments	Download
	M	build/android.gypi	View		6 chunks	+36 lines, -25 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 3 months ago (2012-09-03 11:18:18 UTC) #2

LGTM with a nit.

https://chromiumcodereview.appspot.com/10910062/diff/1/build/android.gypi
File build/android.gypi (right):

https://chromiumcodereview.appspot.com/10910062/diff/1/build/android.gypi#new...
build/android.gypi:61: }]
nit: trailing comma please

Expand Messages | Collapse Messages