Issue 10910061: Add a script to manage the content shell command-line flags.

Issue 10910061: Add a script to manage the content shell command-line flags. (Closed)

Created:
8 years, 3 months ago by Iain Merrick

Modified:
8 years, 3 months ago

Reviewers:
Ted C, bulach, Isaac (away)

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add a script to manage the content shell command-line flags. BUG=145222 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155237

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	A	build/android/adb_content_shell_command_line	View		1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Iain Merrick

Hi Ted, just wanted to check that you noticed this patch. I copied your original ...

8 years, 3 months ago (2012-09-06 16:23:50 UTC) #2

Iain Merrick

On 2012/09/06 16:33:13, Ted C wrote: > lgtm > > Do'h...thanks for the ping! Slipped ...

8 years, 3 months ago (2012-09-06 16:46:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10910061/1

8 years, 3 months ago (2012-09-06 16:47:58 UTC) #5

Isaac (away)

Hi Iain, especially for files intended to be used by buildbot, please check with relevant ...

8 years, 3 months ago (2012-09-06 22:21:37 UTC) #7

bulach

8 years, 3 months ago (2012-09-07 09:02:25 UTC) #8

+1 for doing it in python.. we already have a component in
build/android/pylib/flag_changer.py... it needs some tweaking, as it's only
changing chrome flags, but it'd be nice to have a wrapper in build/android for
it..

Expand Messages | Collapse Messages