webkit/appcache/appcache_update_job.cc - Issue 10910044: Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_update_job.cc

Issue 10910044: Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/resource_dispatcher_host_impl.cc ('k') | webkit/appcache/appcache_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/appcache/appcache_update_job.cc

diff --git a/webkit/appcache/appcache_update_job.cc b/webkit/appcache/appcache_update_job.cc

index 29e3b1a44e63e12bb7f4cfc6b2b356c4faf5a4a3..10929042e6aed2cda1935604c1c74a778328ff23 100644

--- a/webkit/appcache/appcache_update_job.cc

+++ b/webkit/appcache/appcache_update_job.cc

@@ -15,6 +15,7 @@

#include "net/base/net_errors.h"

#include "net/http/http_request_headers.h"

#include "net/http/http_response_headers.h"

+#include "net/url_request/url_request_context.h"

#include "webkit/appcache/appcache_group.h"

#include "webkit/appcache/appcache_histograms.h"

@@ -97,10 +98,8 @@ AppCacheUpdateJob::URLFetcher::URLFetcher(

fetch_type_(fetch_type),

retry_503_attempts_(0),

buffer_(new net::IOBuffer(kBufferSize)),

- ALLOW_THIS_IN_INITIALIZER_LIST(

- request_(new net::URLRequest(url,

- this,

- job->service_->request_context()))) {

+ ALLOW_THIS_IN_INITIALIZER_LIST(request_(

+ job->service_->request_context()->CreateRequest(url, this))) {

}

AppCacheUpdateJob::URLFetcher::~URLFetcher() {

@@ -288,9 +287,7 @@ bool AppCacheUpdateJob::URLFetcher::MaybeRetryRequest() {

return false;

}

++retry_503_attempts_;

- request_.reset(new net::URLRequest(url_,

- this,

- job_->service_->request_context()));

+ request_.reset(job_->service_->request_context()->CreateRequest(url_, this));

Start();

return true;

}