Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10910044: Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest (Closed)

Created:
8 years, 3 months ago by erikwright (departed)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, oshima+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, stuartmorgan+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest This patch is by departed intern shalev@chromium.org, but it failed to pass the CQ for reasons unrelated to the patch. Original review at http://codereview.chromium.org/10870060/ . TBR=mmenke@chromium.org,michaeln@chromium.org,brettw@chromium.org,ben@chromium.org,zelidrag@chromium.org,phajdan.jr@chromium.org,pfeldman@chromium.org BUG=142945 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -78 lines) Patch
M chrome/browser/net/chrome_fraudulent_certificate_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_update_job.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 4 chunks +8 lines, -16 lines 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/chromeos/fileapi/remote_file_system_operation.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webkit/fileapi/local_file_system_operation.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10910044/1
8 years, 3 months ago (2012-08-31 19:48:08 UTC) #1
commit-bot: I haz the power
8 years, 3 months ago (2012-09-01 00:19:33 UTC) #2 
Change committed as 154550

Powered by Google App Engine
This is Rietveld 408576698