Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10910026: Show about:sandbox status in the about:gpu page. (Closed)

Created:
8 years, 3 months ago by skaslev
Modified:
8 years, 3 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Show about:sandbox status in the about:gpu page. BUG=144663 R=nduca@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155078

Patch Set 1 #

Patch Set 2 : Show about:sandbox status in the about:gpu page. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -4 lines) Patch
M chrome/browser/resources/gpu_internals/browser_bridge.js View 3 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/resources/gpu_internals/info_view.html View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/gpu_internals/info_view.js View 2 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 1 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nduca
LGTM but lets let @jbauman have a review, too if thats ok?
8 years, 3 months ago (2012-08-31 23:18:20 UTC) #1
M-A Ruel
Warning: do not trust the try job results on patchset 6: many are green but ...
8 years, 3 months ago (2012-09-02 18:56:22 UTC) #2
M-A Ruel
On 2012/09/02 18:56:22, Marc-Antoine Ruel wrote: > Warning: do not trust the try job results ...
8 years, 3 months ago (2012-09-02 18:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skaslev@google.com/10910026/5001
8 years, 3 months ago (2012-09-05 21:27:05 UTC) #4
commit-bot: I haz the power
Presubmit check for 10910026-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-05 21:27:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skaslev@google.com/10910026/5001
8 years, 3 months ago (2012-09-05 22:10:17 UTC) #6
commit-bot: I haz the power
Presubmit check for 10910026-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-05 22:10:20 UTC) #7
Evan Stade
lgtm
8 years, 3 months ago (2012-09-05 22:26:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skaslev@google.com/10910026/5001
8 years, 3 months ago (2012-09-05 22:27:56 UTC) #9
commit-bot: I haz the power
Change committed as 155078
8 years, 3 months ago (2012-09-06 00:51:15 UTC) #10
jln (very slow on Chromium)
On 2012/09/06 00:51:15, I haz the power (commit-bot) wrote: > Change committed as 155078 Err, ...
8 years, 3 months ago (2012-09-06 01:25:54 UTC) #11
skaslev
8 years, 3 months ago (2012-09-06 01:34:33 UTC) #12 
On 2012/09/06 01:25:54, Julien Tinnes wrote:
> On 2012/09/06 00:51:15, I haz the power (commit-bot) wrote:
> > Change committed as 155078
> 
> Err, I really wish I had been CC-ed on this. The ZygoteHost returns the status
> of the renderer sandbox, not the GPU one.
> 
> Couldn't you use the return value of InitializeSandbox() as I mentioned in the
> bug and bubble-it up ?
> 
> Also the rest of the status (from the Zygote) is irrelevant to the GPU
sandbox,
> the GPU process does not run inside the Zygote or the setuid sandbox.

I'm sorry about that. I followed what the bug said which was to show the
about:sandbox status in the about:gpu page.

I'll make it show the value from InitializeSandbox in a following commit and
I'll make sure that you're CC-ed.

Powered by Google App Engine
This is Rietveld 408576698