Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 10910013: Remove instances of dart:dom_deprecated from outside of lib/html and lib/dom. Part 1 of many. (Closed)

Created:
8 years, 3 months ago by Emily Fortuna
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org, compiler-dev_dartlang.org
Visibility:
Public.

Description

Remove instances of dart:dom_deprecated from outside of lib/html and lib/dom. There are several references in utils/apidoc as well, but that will be a separate CL since it's going to require some substantial changes both in the lib/dom/scripts end and in utils/apidoc. Committed: https://code.google.com/p/dart/source/detail?r=11651

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13369 lines) Patch
M compiler/api.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/_internal/libraries.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/compiler/implementation/apiimpl.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 chunk +1 line, -3 lines 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_any.config View 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_dart2js.config View 1 chunk +0 lines, -1 line 0 comments Download
M lib/config/import_dartium.config View 1 chunk +0 lines, -1 line 0 comments Download
D pkg/unittest/dom_config.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M pkg/unittest/unittest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D samples/matrix/float32.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D samples/matrix/matrix4.dart View 1 chunk +0 lines, -369 lines 0 comments Download
M samples/matrix/matrix_client.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M samples/matrix/matrix_server.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D samples/swarm/htmlconverter.py View 1 chunk +0 lines, -557 lines 0 comments Download
D samples/swarm/htmlconverter_test.py View 1 chunk +0 lines, -414 lines 0 comments Download
M samples/third_party/dromaeo/Suites.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M samples/third_party/dromaeo/tests/RunnerSuite.dart View 1 chunk +1 line, -7 lines 2 comments Download
D samples/third_party/dromaeo/tests/dom-attr-dom.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-attr-dom.html View 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-dom.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-modify-dom.html View 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-dom.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-query-dom.html View 1 chunk +0 lines, -2900 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-dom.dart View 1 chunk +0 lines, -89 lines 0 comments Download
D samples/third_party/dromaeo/tests/dom-traverse-dom.html View 1 chunk +0 lines, -2900 lines 0 comments Download
M tests/compiler/dart2js_foreign/native_call_arity1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_call_arity3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity1_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_call_arity3_frog_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Emily Fortuna
This removes all mentions of dart:dom_deprecated in our repo with the exception of editor uses ...
8 years, 3 months ago (2012-08-30 19:51:34 UTC) #1
Emily Fortuna
+[compiler-dev]
8 years, 3 months ago (2012-08-30 19:52:15 UTC) #2
dgrove
lgtm
8 years, 3 months ago (2012-08-30 19:56:22 UTC) #3
ahe
dart2js changes, LGTM!
8 years, 3 months ago (2012-08-30 19:59:24 UTC) #4
gram
unit test changes lgtm
8 years, 3 months ago (2012-08-30 20:06:30 UTC) #5
Emily Fortuna
Siggi, can you please review the Dromaeo test changes since Vijay and Stephen are out?
8 years, 3 months ago (2012-08-30 20:15:27 UTC) #6
Siggi Cherem (dart-lang)
changes lgtm, but I don't know if there is interest in continue measuring the $dom_ ...
8 years, 3 months ago (2012-08-30 20:26:21 UTC) #7
Emily Fortuna
8 years, 3 months ago (2012-08-30 20:28:06 UTC) #8
https://chromiumcodereview.appspot.com/10910013/diff/3032/samples/third_party...
File samples/third_party/dromaeo/tests/RunnerSuite.dart (left):

https://chromiumcodereview.appspot.com/10910013/diff/3032/samples/third_party...
samples/third_party/dromaeo/tests/RunnerSuite.dart:26:
_window.addEventListener('message', starter, false);
On 2012/08/30 20:26:21, sigmund wrote:
> mmm.. not sure if they would like to keep also a benchmark that measures
> _window.$dom_addEventListener ?

We stopped tracking this a while ago on the bots. If we decide we want to track
this, let's make it a separate specific benchmark.

Powered by Google App Engine
This is Rietveld 408576698