Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 10910004: Disable ChromeContentRendererClientTest.NaClRestriction on ARM. (Closed)

Created:
8 years, 3 months ago by Iain Merrick
Modified:
8 years, 3 months ago
Reviewers:
sehr, Nico, Derek Schuff
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable ChromeContentRendererClientTest.NaClRestriction on ARM. This tests the NaCl content-type rules, which were modified for ARM only in patch 154043 (https://chromiumcodereview.appspot.com/10898034). As this is a temporary change with TODO(dschuff), I've just disabled the whole test with the same TODO. R=dschuff@chromium.org,thakis@chromium.org,sehr@chromium.org BUG=145694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154276

Patch Set 1 #

Patch Set 2 : Added bug ID to TODOs #

Total comments: 2

Patch Set 3 : Nice short URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Iain Merrick
Needed to keep the Android buildbot green.
8 years, 3 months ago (2012-08-30 13:54:51 UTC) #1
Nico
Since it's now in two places, can you file a bug for reenabling this and ...
8 years, 3 months ago (2012-08-30 15:23:48 UTC) #2
Derek Schuff
Sorry about that, and thanks. Filed bug https://code.google.com/p/chromium/issues/detail?id=145694 and updated BUG= in issue On 2012/08/30 ...
8 years, 3 months ago (2012-08-30 15:59:01 UTC) #3
Iain Merrick
I'll update the comments
8 years, 3 months ago (2012-08-30 16:01:15 UTC) #4
Nico
Say just "BUG=145694" in the CL description, then rietveld will auto-linkify it (if you want ...
8 years, 3 months ago (2012-08-30 16:14:58 UTC) #5
Iain Merrick
http://codereview.chromium.org/10910004/diff/4002/chrome/renderer/chrome_content_renderer_client.cc File chrome/renderer/chrome_content_renderer_client.cc (right): http://codereview.chromium.org/10910004/diff/4002/chrome/renderer/chrome_content_renderer_client.cc#newcode612 chrome/renderer/chrome_content_renderer_client.cc:612: // https://code.google.com/p/chromium/issues/detail?id=145694 On 2012/08/30 16:14:58, Nico wrote: > nit: ...
8 years, 3 months ago (2012-08-30 16:53:39 UTC) #6
Derek Schuff
LGTM btw, not that it means anything. On 2012/08/30 16:53:39, Iain Merrick wrote: > http://codereview.chromium.org/10910004/diff/4002/chrome/renderer/chrome_content_renderer_client.cc ...
8 years, 3 months ago (2012-08-30 16:55:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10910004/8002
8 years, 3 months ago (2012-08-30 16:55:39 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 21:48:58 UTC) #9
Change committed as 154276

Powered by Google App Engine
This is Rietveld 408576698