Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10909282: Switch SnapshotTabHelper to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Switch SnapshotTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M chrome/browser/extensions/api/tabs/tabs.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/snapshot_tab_helper.h View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/snapshot_tab_helper.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
8 years, 3 months ago (2012-09-17 21:51:33 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-17 21:54:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10909282/1
8 years, 3 months ago (2012-09-17 22:04:33 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 22:13:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10909282/1
8 years, 3 months ago (2012-09-17 22:21:55 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 22:31:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10909282/1
8 years, 3 months ago (2012-09-17 22:37:04 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 00:16:57 UTC) #8
Change committed as 157252

Powered by Google App Engine
This is Rietveld 408576698