Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: chrome/browser/extensions/extension_tab_util.h

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Realized that any API outside of tabs.json and windows.json that referenced tabs.Tab would have sam… Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.h
diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h
index 0261164a8d5eecde9114f3fdb8a9f7d6800c82b9..de81e8ba807b547760adbb294335eddad69bd7f9 100644
--- a/chrome/browser/extensions/extension_tab_util.h
+++ b/chrome/browser/extensions/extension_tab_util.h
@@ -45,19 +45,33 @@ class ExtensionTabUtil {
static base::ListValue* CreateTabList(
const Browser* browser,
const extensions::Extension* extension);
+
static base::DictionaryValue* CreateTabValue(
const content::WebContents* web_contents,
- const extensions::Extension* extension);
+ const extensions::Extension* extension) {
+ return CreateTabValue(web_contents, NULL, -1, extension);
+ }
static base::DictionaryValue* CreateTabValue(
const content::WebContents* web_contents,
TabStripModel* tab_strip,
int tab_index,
const extensions::Extension* extension);
- // Create a tab value, overriding its kSelectedKey to the provided boolean.
- static base::DictionaryValue* CreateTabValueActive(
+
+ enum IncludePrivacySensitiveFields {
+ INCLUDE_PRIVACY_SENSITIVE_FIELDS,
+ OMIT_PRIVACY_SENSITIVE_FIELDS
+ };
+ static base::DictionaryValue* CreateTabValue(
const content::WebContents* web_contents,
- bool active,
- const extensions::Extension* extension);
+ IncludePrivacySensitiveFields include_privacy_sensitive_fields) {
+ return CreateTabValue(web_contents, NULL, -1,
+ include_privacy_sensitive_fields);
+ }
+ static base::DictionaryValue* CreateTabValue(
+ const content::WebContents* web_contents,
+ TabStripModel* tab_strip,
+ int tab_index,
+ IncludePrivacySensitiveFields include_privacy_sensitive_fields);
// Gets the |tab_strip_model| and |tab_index| for the given |web_contents|.
static bool GetTabStripModel(const content::WebContents* web_contents,

Powered by Google App Engine
This is Rietveld 408576698