chrome/test/data/extensions/api_test/browser_action/basics/manifest.json - Issue 10909256: Always send the full tab object in ExtensionAction click event.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/browser_action/basics/manifest.json

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: kalments Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "name": "A browser action with no icon that makes the page red",	2 "name": "A browser action with no icon that makes the page red",

3 "version": "1.0",	3 "version": "1.0",

4 "manifest_version": 2,	4 "manifest_version": 2,

5 "background": {	5 "background": {

6 "scripts": ["background.js"]	6 "scripts": ["background.js"]

7 },	7 },

8 "permissions": [	8 "permissions": [

9 "tabs", "http:///"	9 "http:///"

10 ],	10 ],

11 "browser_action": {	11 "browser_action": {

12 "default_title": "Make this page red",	12 "default_title": "Make this page red",

13 "default_icon": "icon.png"	13 "default_icon": "icon.png"

14 }	14 }

15 }	15 }

OLD	NEW