Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/api_test/browser_action/basics/background.js

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: kalments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/test/data/extensions/api_test/browser_action/basics/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Called when the user clicks on the browser action. 5 // Called when the user clicks on the browser action.
6 chrome.browserAction.onClicked.addListener(function(windowId) { 6 chrome.browserAction.onClicked.addListener(function(tab) {
7 chrome.tabs.executeScript(null, {code:"document.body.bgColor='red'"}); 7 // Privacy-sensitive properties are treated specially. Ensure they are
8 // present.
9 chrome.test.assertTrue(Boolean(tab.url.length));
10 chrome.test.assertTrue(Boolean(tab.title.length));
11
12 // Everything else is handled in a general way and should of course also
13 // be present.
14 chrome.test.assertTrue(Boolean(tab.id));
15 chrome.test.notifyPass();
8 }); 16 });
9 17
10 chrome.test.notifyPass(); 18 chrome.test.notifyPass();
OLDNEW
« no previous file with comments | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/test/data/extensions/api_test/browser_action/basics/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698