Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10909254: Fix svn copies for apply_issue (Closed)

Created:
8 years, 3 months ago by Isaac (away)
Modified:
8 years, 3 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Fix svn copies for apply_issue _check_output_svn sets the cwd to project_path therefore files should not have project_path. R=maruel@chromium.org,cmp@chromium.org BUG=149702 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M checkout.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Isaac (away)
8 years, 3 months ago (2012-09-15 00:24:16 UTC) #1
M-A Ruel
Humm I really wonder why I did this error. Thanks! lgtm
8 years, 3 months ago (2012-09-15 00:33:24 UTC) #2
Isaac (away)
I was trying to figure out why this didn't occur on my local tree. I ...
8 years, 3 months ago (2012-09-15 01:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10909254/1
8 years, 3 months ago (2012-09-15 01:34:30 UTC) #4
commit-bot: I haz the power
Change committed as 156953
8 years, 3 months ago (2012-09-15 01:37:22 UTC) #5
cmp
8 years, 3 months ago (2012-09-15 01:45:15 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698