Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: utils/testrunner/pipeline_task.dart

Issue 10909240: Support for pixel layout tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/testrunner/pipeline_task.dart
===================================================================
--- utils/testrunner/pipeline_task.dart (revision 12573)
+++ utils/testrunner/pipeline_task.dart (working copy)
@@ -8,7 +8,7 @@
*/
abstract class PipelineTask {
- abstract void execute(Path testfile, List stdout, List stderr,
+ abstract execute(Path testfile, List stdout, List stderr,
bool logging, Function exitHandler);
void cleanup(Path testfile, List stdout, List stderr,
@@ -20,9 +20,14 @@
if (!keepFiles) {
for (var template in templates) {
var fname = expandMacros(template, testfile);
- deleteFile(fname);
- if (logging) {
- stdout.add('Removing $fname');
+ if (deleteFile(fname)) {
+ if (logging) {
+ stdout.add('Removed $fname');
+ }
+ } else {
+ if (logging) {
+ stdout.add('Failed to remove $fname');
+ }
}
}
}

Powered by Google App Engine
This is Rietveld 408576698