Support for pixel layout tests.

utils/testrunner/layout_test_runner.dart

+/** The filters must be set by the caller. */

[Siggi Cherem (dart-lang), 2012/09/20 17:37:27]

+ copyright
+ library

since this comment is not a dartdoc associated with the following field, you
might want to switch it to a normal comment (e.g. //)

also, same question as in the other file, who is the caller?

[gram, 2012/09/20 18:58:03]

Done.

+List includeFilters;
+List excludeFilters;
+
+class LayoutTestConfiguration extends unittest.Configuration {
+  get autoStart => false;
+  void onTestResult(unittest.TestCase testCase) {
+    window.postMessage('done', '*'); // Unblock DRT
+  }
+}
+
+filterTest(t) {
+  var name = t.description.replaceAll("###", " ");
+  if (includeFilters.length > 0) {
+    for (var f in includeFilters) {
+      if (name.indexOf(f) >= 0) return true;
+    }
+    return false;
+  } else if (excludeFilters.length > 0) {
+    for (var f in excludeFilters) {
+      if (name.indexOf(f) >= 0) return false;
+    }
+    return true;
+  } else {
+    return true;
+  }
+}
+
+runTests(testMain) {
+  unittest.groupSep = '###';
+  unittest.configure(new LayoutTestConfiguration());
+  // Create the set of test cases.

[Siggi Cherem (dart-lang), 2012/09/20 17:37:27]

nit: always add an empty line before a line comment (here and below)

[gram, 2012/09/20 18:58:03]

Done.

+  unittest.group('', testMain);
+  // Do any user-specified test filtering.
+  unittest.filterTests(filterTest);
+  // Filter to the test number in the search query.
+  var testNum = int.parse(window.location.search.substring(6));
+  if (testNum < 0 || testNum >= unittest.testCases.length) {
+    print('#TEST NONEXISTENT');
+    window.postMessage('done', '*'); // Unblock DRT
+  } else {
+    var name = unittest.testCases[testNum].description;
+    print('#TEST $name');
+    unittest.filterTests(name);
+    // Run the test.
+    print('Tests - ${unittest.testCases.length}');
+    unittest.runTests();
+  }
+}
+

[Siggi Cherem (dart-lang), 2012/09/20 17:37:27]

nit: remove empty line

[gram, 2012/09/20 18:58:03]

Done.