Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/common/extensions/extension.h

Issue 10909239: Rename PACKAGED_APP references to LEGACY_PACKAGED_APP (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/csp_validator_unittest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index ec4b54d6aeed4e47a945f1f8e610db49f5c1583d..e73761b491d63a12defb0c231792232f5330061a 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -131,7 +131,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
TYPE_THEME,
TYPE_USER_SCRIPT,
TYPE_HOSTED_APP,
- TYPE_PACKAGED_APP,
+ // This is marked legacy because platform apps are preferred. For
+ // backwards compatibility, we can't remove support for packaged apps
Nico 2012/09/28 01:38:15 nit: trailing .
+ TYPE_LEGACY_PACKAGED_APP,
TYPE_PLATFORM_APP
};
@@ -723,11 +725,11 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// App-related.
bool is_app() const {
- return is_packaged_app() || is_hosted_app() || is_platform_app();
+ return is_legacy_packaged_app() || is_hosted_app() || is_platform_app();
}
bool is_platform_app() const;
bool is_hosted_app() const;
- bool is_packaged_app() const;
+ bool is_legacy_packaged_app() const;
bool is_storage_isolated() const { return is_storage_isolated_; }
const URLPatternSet& web_extent() const { return extent_; }
const std::string& launch_local_path() const { return launch_local_path_; }
« no previous file with comments | « chrome/common/extensions/csp_validator_unittest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698