Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 10909236: Add support for favicon scale factor in WebUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix HandleGetFaviconDominantColor. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 141761f870aaa57887787704beedeccdcb712eda..ae9e5a8a669a6e6ad916eb3f8b4fb0c0cf188d33 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -96,9 +96,11 @@ cr.define('options.search_engines', function() {
// Add the favicon.
var faviconDivEl = this.ownerDocument.createElement('div');
faviconDivEl.className = 'favicon';
- var imgEl = this.ownerDocument.createElement('img');
- imgEl.src = 'chrome://favicon/iconurl/' + engine.iconURL;
- faviconDivEl.appendChild(imgEl);
+ if (!this.isPlaceholder) {
+ faviconDivEl.style.backgroundImage =
+ url('chrome://favicon/iconurl@' + window.devicePixelRatio + 'x/' +
+ engine.iconURL);
+ }
nameColEl.appendChild(faviconDivEl);
var nameEl = this.createEditableTextCell(engine.displayName);
« no previous file with comments | « chrome/browser/resources/options/search_engine_manager.css ('k') | chrome/browser/resources/shared/js/util.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698