Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10909230: Fixed new promo banner showing condition. (Closed)

Created:
8 years, 3 months ago by SeRya
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fixed new promo banner showing condition. BUG= TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157108

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -31 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/file_manager/js/drive_banners.js View 1 7 chunks +65 lines, -24 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/manifest.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
SeRya
8 years, 3 months ago (2012-09-14 12:10:53 UTC) #1
SeRya
8 years, 3 months ago (2012-09-14 12:11:06 UTC) #2
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/10909230/diff/4001/chrome/browser/resources/file_manager/js/drive_banners.js File chrome/browser/resources/file_manager/js/drive_banners.js (right): https://chromiumcodereview.appspot.com/10909230/diff/4001/chrome/browser/resources/file_manager/js/drive_banners.js#newcode432 chrome/browser/resources/file_manager/js/drive_banners.js:432: var self = this; Why not bind(this)? It would ...
8 years, 3 months ago (2012-09-14 12:18:45 UTC) #3
SeRya
https://chromiumcodereview.appspot.com/10909230/diff/4001/chrome/browser/resources/file_manager/js/drive_banners.js File chrome/browser/resources/file_manager/js/drive_banners.js (right): https://chromiumcodereview.appspot.com/10909230/diff/4001/chrome/browser/resources/file_manager/js/drive_banners.js#newcode432 chrome/browser/resources/file_manager/js/drive_banners.js:432: var self = this; On 2012/09/14 12:18:45, Vladislav Kaznacheev ...
8 years, 3 months ago (2012-09-14 14:36:23 UTC) #4
Vladislav Kaznacheev
lgtm
8 years, 3 months ago (2012-09-14 14:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10909230/3005
8 years, 3 months ago (2012-09-15 09:39:13 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-15 10:19:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10909230/3005
8 years, 3 months ago (2012-09-17 09:36:25 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 09:36:26 UTC) #9 
Failed to apply patch for chrome/browser/resources/file_manager/manifest.json:
While running patch -p1 --forward --force;
patching file chrome/browser/resources/file_manager/manifest.json
Hunk #1 FAILED at 20.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/file_manager/manifest.json.rej

Powered by Google App Engine
This is Rietveld 408576698