Removes caching of whether the launcher should be visible from

Removes caching of whether the launcher should be visible from
StatusAreaWidget and instead queries as necessary. The problem is the
current code was caching things based on mouse location, but it wasn't
always updating when the mouse moved. Since the shelf has its own
mouse handler that queries for state it isn't necessary to duplicate
that in the tray.

BUG=148548
TEST=see bug
R=sadrul@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156740

[sadrul, 2012-09-13 23:31:26]

http://codereview.chromium.org/10909220/diff/2001/ash/system/status_area_widg...
File ash/system/status_area_widget.h (right):

http://codereview.chromium.org/10909220/diff/2001/ash/system/status_area_widg...
ash/system/status_area_widget.h:73: // launcher is configured to aut-hide and
test if the shelf should force
auto-hide

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (left):

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:910:
tray_->UpdateShouldShowLauncher();
Can this break 'do not hide launcher if mouse is in a notification bubble'?
(e.g. if the mouse comes into the bubble after the auto-hide timer in the SLM
starts) Should this call UpdateAutoHideState()?

[sky, 2012-09-14 00:06:35]

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (left):

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:910:
tray_->UpdateShouldShowLauncher();
On 2012/09/13 23:31:26, sadrul wrote:
> Can this break 'do not hide launcher if mouse is in a notification bubble'?
> (e.g. if the mouse comes into the bubble after the auto-hide timer in the SLM
> starts) Should this call UpdateAutoHideState()?

While in AUTO_HIDE state the eventfilter in SLM is always active. So, if you
move the mouse out then back in the launcher should stop its auto-hide.

[sadrul, 2012-09-14 00:10:08]

LGTM

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
File ash/system/web_notification/web_notification_tray.cc (left):

http://codereview.chromium.org/10909220/diff/2001/ash/system/web_notification...
ash/system/web_notification/web_notification_tray.cc:910:
tray_->UpdateShouldShowLauncher();
On 2012/09/14 00:06:35, sky wrote:
> On 2012/09/13 23:31:26, sadrul wrote:
> > Can this break 'do not hide launcher if mouse is in a notification bubble'?
> > (e.g. if the mouse comes into the bubble after the auto-hide timer in the
SLM
> > starts) Should this call UpdateAutoHideState()?
> 
> While in AUTO_HIDE state the eventfilter in SLM is always active. So, if you
> move the mouse out then back in the launcher should stop its auto-hide.

Oh, cool!

[commit-bot: I haz the power, 2012-09-14 02:01:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/10909220/7001

[commit-bot: I haz the power, 2012-09-14 04:22:36]

Change committed as 156740