Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10909218: Add some missing unit tests and update cc_unittests and webkit_compositor_bindings_unittests (Closed)

Created:
8 years, 3 months ago by shawnsingh
Modified:
8 years, 3 months ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add some missing unit tests and update cc_unittests and webkit_compositor_bindings_unittests After GTFO, some unit test files were not in the right place, or missing entirely. This patch (1) adds some missing unit tests, (2) moves some tests from webkit_compositor_bindings_unitttests to cc_unitttests, and (3) removes some redundant entries in the gyp files for those targets. BUG=https://code.google.com/p/chromium/issues/detail?id=149121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157425

Patch Set 1 #

Patch Set 2 : One more try... #

Patch Set 3 : #

Patch Set 4 : This version is promising #

Patch Set 5 : Updated to tip of tree, fixed try bot errors #

Patch Set 6 : Updated to tip of tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4079 lines, -3060 lines) Patch
A cc/CCDrawQuadTest.cpp View 1 2 3 1 chunk +312 lines, -0 lines 0 comments Download
A cc/CCRenderPassTest.cpp View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
A cc/CCRendererGLTest.cpp View 1 2 3 4 5 1 chunk +428 lines, -0 lines 0 comments Download
A cc/ContentLayerChromiumTest.cpp View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A cc/LayerChromiumTest.cpp View 1 2 3 4 1 chunk +847 lines, -0 lines 0 comments Download
A cc/ScrollbarLayerChromiumTest.cpp View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download
A cc/TextureCopierTest.cpp View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A cc/TextureLayerChromiumTest.cpp View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
A cc/ThrottledTextureUploaderTest.cpp View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A cc/TiledLayerChromiumTest.cpp View 1 2 3 4 5 1 chunk +1547 lines, -0 lines 0 comments Download
A cc/TreeSynchronizerTest.cpp View 1 2 1 chunk +405 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 3 chunks +11 lines, -1 line 0 comments Download
D webkit/compositor_bindings/LayerChromiumTest.cpp View 1 2 1 chunk +0 lines, -847 lines 0 comments Download
D webkit/compositor_bindings/TextureCopierTest.cpp View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
D webkit/compositor_bindings/TextureLayerChromiumTest.cpp View 1 2 1 chunk +0 lines, -121 lines 0 comments Download
D webkit/compositor_bindings/ThrottledTextureUploaderTest.cpp View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
D webkit/compositor_bindings/TiledLayerChromiumTest.cpp View 1 2 3 4 5 1 chunk +0 lines, -1547 lines 0 comments Download
D webkit/compositor_bindings/TreeSynchronizerTest.cpp View 1 2 1 chunk +0 lines, -405 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings_tests.gyp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
shawnsingh
First few try attempts, the path was moving several files from webkit/compositor_bindings/ to cc/. I ...
8 years, 3 months ago (2012-09-14 00:43:07 UTC) #1
enne (OOO)
Looks like you've been bitten by my WebCore => cc namespace change.
8 years, 3 months ago (2012-09-17 20:40:51 UTC) #2
shawnsingh
I think this is the patch that will probably pass all try bots. =) I ...
8 years, 3 months ago (2012-09-17 21:38:32 UTC) #3
shawnsingh
8 years, 3 months ago (2012-09-17 21:38:54 UTC) #4
jamesr
lgtm
8 years, 3 months ago (2012-09-17 22:42:38 UTC) #5
shawnsingh
On 2012/09/17 22:42:38, jamesr wrote: > lgtm Thanks for review -- as long as you ...
8 years, 3 months ago (2012-09-17 22:58:12 UTC) #6
jamesr
On 2012/09/17 22:58:12, shawnsingh wrote: > On 2012/09/17 22:42:38, jamesr wrote: > > lgtm > ...
8 years, 3 months ago (2012-09-17 23:09:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/10909218/18001
8 years, 3 months ago (2012-09-17 23:13:00 UTC) #8
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 02:49:35 UTC) #9
shawnsingh
On 2012/09/18 02:49:35, I haz the power (commit-bot) wrote: > Retried try job too often ...
8 years, 3 months ago (2012-09-18 18:50:53 UTC) #10
jamesr
lgtm
8 years, 3 months ago (2012-09-18 19:33:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/10909218/25001
8 years, 3 months ago (2012-09-18 19:44:06 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 21:51:42 UTC) #13
Change committed as 157425

Powered by Google App Engine
This is Rietveld 408576698