Issue 10909187: Use the new favicon resources below common/, delete the old assets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909187: Use the new favicon resources below common/, delete the old assets (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use the new favicon resources below common/, delete the old assets Consolidate to the new favicon_foo naming scheme preferred by ux. BUG=none TBR=oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156252

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-19 lines, --19 lines)			Patch
D	chrome/app/theme/default_100_percent/about_conflicts_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/bookmarks_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/about_conflicts_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/bookmarks_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/downloads_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/flags.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/history_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/plugin.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/print_preview_favicon.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/sadfavicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/settings_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/downloads_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/flags.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/history_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/plugin.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/sadfavicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/settings_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/about_conflicts_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/bookmarks_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/about_conflicts_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/bookmarks_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/downloads_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/flags.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/history_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/plugin.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/print_preview_favicon.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/sadfavicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/settings_favicon.png	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/downloads_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/flags.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/history_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/plugin.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/print_preview_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/sadfavicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/settings_favicon.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/print_preview_favicon.png	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1	8 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager/task_manager_notification_resource_provider.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_worker_resource_provider.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/flags_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/plugins_ui.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages